[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci] #10902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tary lists. (#10880) Fixes: #10855 Unsanitary lists (those with null rows that actually have backing underlying data) should not compare as equal to sanitized lists, but _should_ compare as equivalent. Only one test in cudf was affected by this change, which I've opened a second issue for: #10856 This PR also adds a utility function to `cudf::test::lists_column_wrapper`, `static lists_column_wrapper<T> make_one_empty_row_column(bool valid = true)` Due to the way initializer lists and nested class initialization work, it was impossible to create a list column with 1 row that was empty, so I added this explicit function to handle the edge case. Authors: - https://github.com/nvdbaranec Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Mark Harris (https://github.com/harrism) - Nghia Truong (https://github.com/ttnghia) URL: #10880
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-22.06that creates a PR to keepbranch-22.08up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.